update AdvancedTlsX509KeyManager to support key alias for reloaded cert#12686
Open
zhangweikop wants to merge 1 commit intogrpc:masterfrom
Open
update AdvancedTlsX509KeyManager to support key alias for reloaded cert#12686zhangweikop wants to merge 1 commit intogrpc:masterfrom
zhangweikop wants to merge 1 commit intogrpc:masterfrom
Conversation
a54cf0b to
a18d1a6
Compare
a18d1a6 to
9456de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Make the alias in
AdvancedTlsX509KeyManagerdynamic so it can be used with Netty'sOpenSslCachingX509KeyManagerFactoryto update key material after reload.Fixes #12670
Problem
When using
SslProvider.OPENSSL, each TLS handshake must encode Java key material into a nativebuffer consumed by OpenSSL, which can account for ~8% of server CPU. Netty's
OpenSslCachingX509KeyManagerFactoryavoids this by caching the encoded buffer keyed by alias —but the previous implementation always returned
"default", so the factory could never detectcredential rotations and create a new cache entry on cert reload.
Details
key-<N>(e.g.key-1,key-2, ...) and incremented on everyupdateIdentityCredentialscall, ensuring the same alias always maps to the same key material.AdvancedTlsX509KeyManager(int revisionWarningThreshold)allows customizingthe soft warning threshold (default: 1024, matching
OpenSslCachingX509KeyManagerFactory'sdefault
maxCachedEntries). A warning is logged when the counter reaches the threshold, sincebeyond that point new aliases won't be cached and per-handshake encoding overhead resumes. The
key manager remains fully functional past this threshold.
nullbefore any credentials are loaded.